fix: pass through max tokens for non-mantle Bedrock models#1719
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
|
Hi @Tommypop2 , the export fix is correct - the exported But I traced #1718 through the managed-harness path and I don't think this PR closes it. The issue's repro is On the managed path, So the "field is empty" symptom isn't reproduced by the current code on the managed path. Before merging as "Closes #1718", can you confirm:
If it's a managed-harness issue it's likely either an older UI version or server-side (harness service not honoring |
|
Claude Security Review: no high-confidence findings. (run) |
|
Hi! "model": {
"provider": "bedrock",
"modelId": "global.anthropic.claude-sonnet-5",
"maxTokens": 32000
},The changes did seem to fix the issue, though I guess that can't be true if the I'm on CLI version v0.23.0. Thanks! |
|
Done some more testing: Thanks :) |
|
Claude Security Review: no high-confidence findings. (run) |
…ck (#1729) * fix(dev): apply model config for all providers in dev, not just Bedrock #1719 defaulted the harness invoke model from the local spec so agentcore.json model settings (notably maxTokens) apply in dev without a redeploy — but only for Bedrock. OpenAI/Gemini/LiteLLM harnesses still silently used the deployed model config until redeploy. Extract buildModelOverride() to map every provider to its own invoke config key (bedrockModelConfig/openAiModelConfig/geminiModelConfig/liteLlmModelConfig), carrying only the fields each config accepts. Update tests to cover all four. * docs: trim buildModelOverride comment
Description
Ensures that the
maxTokensentry in the configuration is passed through to the agentRelated Issue
Closes #1718
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integ-> 1 failure but this also failed when I rannpm run teston the currentmasternpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.